fix: guard against overflow in sse backoff calculation #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
approved these changes
Oct 8, 2024
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.7.1</summary> ## [3.7.1](launchdarkly-cpp-client-v3.7.0...launchdarkly-cpp-client-v3.7.1) (2024-10-08) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.5.3 to 0.5.4 </details> <details><summary>launchdarkly-cpp-server: 3.6.2</summary> ## [3.6.2](launchdarkly-cpp-server-v3.6.1...launchdarkly-cpp-server-v3.6.2) (2024-10-08) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-sse-client bumped from 0.5.3 to 0.5.4 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.14</summary> ## [2.1.14](launchdarkly-cpp-server-redis-source-v2.1.13...launchdarkly-cpp-server-redis-source-v2.1.14) (2024-10-08) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.6.1 to 3.6.2 </details> <details><summary>launchdarkly-cpp-sse-client: 0.5.4</summary> ## [0.5.4](launchdarkly-cpp-sse-client-v0.5.3...launchdarkly-cpp-sse-client-v0.5.4) (2024-10-08) ### Bug Fixes * guard against overflow in sse backoff calculation ([#455](#455)) ([a3c1e58](a3c1e58)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some platform configurations, the SSE backoff calculation overflows which results in failing to schedule another backoff attempt via
asio::deadline_timer::expires_from_now.This PR refactors the backoff algorithm to use free functions which can be independently tested.
It fixes the bug by constraining the maximum backoff exponent based on the configurable max backoff parameter.
Finally, I've added some test vectors for large attempt values. In the bug report, the overflow happens at about 34 minutes which corresponded to 55 attempts.