fix: Change notification consistency. #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The store should be updated before events are dispatched to ensure consistent data between event information and variation calls.
kinyoklion
force-pushed
the
rlamb/sdk-1057/fix-change-handler-order
branch
from
ebde89a to
dd31298
Compare
louis-launchdarkly
approved these changes
Jan 28, 2025
keelerm84
approved these changes
Jan 28, 2025
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Jan 28, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.8.2</summary> ## [3.8.2](launchdarkly-cpp-client-v3.8.1...launchdarkly-cpp-client-v3.8.2) (2025-01-28) ### Bug Fixes * Change notification consistency. ([#473](#473)) ([45fd755](45fd755)) * Remove type alias import for JSON system_error that was removed in boost 1.87. ([c0ef518](c0ef518)) * Remove vendored boost file to compile with boost 1.87. ([c0ef518](c0ef518)) * Update usage of the steady_timer to be compatible with boost 1.87. ([c0ef518](c0ef518)) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.10.0 to 0.10.1 * launchdarkly-cpp-sse-client bumped from 0.5.4 to 0.5.5 </details> <details><summary>launchdarkly-cpp-internal: 0.10.1</summary> ## [0.10.1](launchdarkly-cpp-internal-v0.10.0...launchdarkly-cpp-internal-v0.10.1) (2025-01-28) ### Bug Fixes * Remove type alias import for JSON system_error that was removed in boost 1.87. ([c0ef518](c0ef518)) * Remove vendored boost file to compile with boost 1.87. ([c0ef518](c0ef518)) * Update usage of the steady_timer to be compatible with boost 1.87. ([c0ef518](c0ef518)) </details> <details><summary>launchdarkly-cpp-server: 3.8.1</summary> ## [3.8.1](launchdarkly-cpp-server-v3.8.0...launchdarkly-cpp-server-v3.8.1) (2025-01-28) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.10.0 to 0.10.1 * launchdarkly-cpp-sse-client bumped from 0.5.4 to 0.5.5 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.17</summary> ## [2.1.17](launchdarkly-cpp-server-redis-source-v2.1.16...launchdarkly-cpp-server-redis-source-v2.1.17) (2025-01-28) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.8.0 to 3.8.1 </details> <details><summary>launchdarkly-cpp-sse-client: 0.5.5</summary> ## [0.5.5](launchdarkly-cpp-sse-client-v0.5.4...launchdarkly-cpp-sse-client-v0.5.5) (2025-01-28) ### Bug Fixes * Remove type alias import for JSON system_error that was removed in boost 1.87. ([c0ef518](c0ef518)) * Remove vendored boost file to compile with boost 1.87. ([c0ef518](c0ef518)) * Update usage of the steady_timer to be compatible with boost 1.87. ([c0ef518](c0ef518)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store should be updated before events are dispatched to ensure consistent data between event information and variation calls.