chore: Add missing features to Akamai SDK metadata (SDK-1884)#1118
chore: Add missing features to Akamai SDK metadata (SDK-1884)#1118
Conversation
Add allFlags, experimentation, secureMode, and track features to both akamai-base and akamai-edgekv entries in .sdk_metadata.json. - allFlags: introduced in 1.0 for both (inherited from LDClientImpl) - secureMode: introduced in 1.0 for both (inherited from LDClientImpl) - experimentation: introduced in 2.0 (akamai-base) / 1.0.8 (akamai-edgekv) - track: introduced in 2.0 (akamai-base) / 1.0.8 (akamai-edgekv) Version differences reflect the different versioning schemes: akamai-base v2.0.0 and akamai-edgekv v1.0.8 correspond to the same 2023-10-16 release that added migrations, typed variations, and trackMigration via js-server-sdk-common v2.0.0. Co-Authored-By: unknown <>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/browser size report |
.sdk_metadata.json
Outdated
| "contexts": { "introduced": "1.0" }, | ||
| "migrations": { "introduced": "1.0.9" } | ||
| "experimentation": { "introduced": "2.0" }, | ||
| "migrations": { "introduced": "1.0.9" }, |
There was a problem hiding this comment.
Fixed — migrations is now "2.0" for akamai-base. Thanks for the correction.
.sdk_metadata.json
Outdated
| "contexts": { "introduced": "1.0" }, | ||
| "migrations": { "introduced": "1.0.9" } | ||
| "experimentation": { "introduced": "1.0.8" }, | ||
| "migrations": { "introduced": "1.0.9" }, |
There was a problem hiding this comment.
Fixed — migrations is now "1.0.8" for akamai-edgekv (the edgekv release that picked up js-server-sdk-common v2.0.0).
.sdk_metadata.json
Outdated
| "allFlags": { "introduced": "1.0" }, | ||
| "contexts": { "introduced": "1.0" }, | ||
| "migrations": { "introduced": "1.0.9" } | ||
| "experimentation": { "introduced": "2.0" }, |
There was a problem hiding this comment.
Experimentation was not 2.0. Probably 1.0.
But only with event sending enabled.
Similarly track is not 2.0, but also only works with event sending enabled.
There was a problem hiding this comment.
Good call — updated both experimentation and track to "1.0" for both SDKs (available from initial release with event sending enabled).
- akamai-base: migrations → 2.0 (was 1.0.9), experimentation → 1.0, track → 1.0 - akamai-edgekv: migrations → 1.0.8 (was 1.0.9), experimentation → 1.0, track → 1.0 Per reviewer: experimentation and track were available from 1.0 (with event sending enabled). Migrations were introduced in akamai-base 2.0.0 and akamai-edgekv 1.0.8 (both corresponding to js-server-sdk-common 2.0.0). Co-Authored-By: unknown <>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
kinyoklion
left a comment
kinyoklion
left a comment
There was a problem hiding this comment.
I am not going to go figure out why, but it looks like 1.0.8 should have been a major version for akamai-edgekv, when we intentionally major versioned node. But maybe it ended up not being because of the missed exports.
Either way, that wasn't a major version because of a break, but because of marketing. So its fine.
2 participants
Requirements
No test changes needed — this is a metadata-only update to
.sdk_metadata.json.Related issues
SDK-1884 — Document complete feature lists for Akamai SDKs. Follows the approach established in PR #1066.
Describe the solution you've provided
Adds four missing features to both
akamai-baseandakamai-edgekventries in.sdk_metadata.json, and corrects themigrationsversion for both:allFlagsallFlagsState()inherited fromLDClientImplsince initial release; confirmed by existing testssecureModesecureModeHash()inherited fromLDClientImplsince initial releaseexperimentationtrackmigrationsjs-server-sdk-commonv2.0.0 uptakeexperimentationandtrackwere included for consistency with all other edge SDKs (cloudflare, vercel, fastly).Updates since last revision
Addressed review feedback from @kinyoklion:
experimentationandtrackset to1.0for both SDKs (available from initial release with event sending enabled), instead of tying them to thejs-server-sdk-commonv2.0.0 bumpmigrationscorrected to2.0for akamai-base (was1.0.9) and1.0.8for akamai-edgekv (was1.0.9)Checklist for human review
experimentationandtrackat1.0is correct — reviewer said "probably 1.0" with event sending enabledmigrationsat2.0for akamai-base and1.0.8for akamai-edgekv are the right introduction pointsDescribe alternatives you've considered
experimentation— decided against this since all other edge SDKs include it alongsidetrack.track/experimentationto thejs-server-sdk-commonv2.0.0 release (akamai-base 2.0, akamai-edgekv 1.0.8) — reviewer clarified these were available from 1.0, just require event sending to be enabled.Additional context
Link to Devin run: https://app.devin.ai/sessions/b417cc1224c84914ad174db637f3a25a
Requested by: @joker23