add: new color prop "status' for notification snackbars and designCard ribbons #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FaheemOnHub <[email protected]>
Signed-off-by: FaheemOnHub <[email protected]>
FaheemOnHub
changed the title
leecalcote
previously requested changes
Sep 8, 2025
There was a problem hiding this comment.
@FaheemOnHub, thank you for this. Two separate concepts are being conflated:
status and severity. Will you please separate the notification severity colors from the catalog content status colors.
|
@FaheemOnHub we separate the catalog status color . lets keep it as separate object |
|
@leecalcote @aabidsofi19 sure I will separate them as different objects. |
Namanv0509
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Signed commits