-
Notifications
You must be signed in to change notification settings - Fork 59
Introduce incremental processing of the commands #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
augustepoiroux
wants to merge
11
commits into
leanprover-community:master
Choose a base branch
from
augustepoiroux:incremental_processing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introduce incremental processing of the commands #109
augustepoiroux
wants to merge
11
commits into
leanprover-community:master
from
augustepoiroux:incremental_processing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5b1011 to
cc50ca5
Compare
cc50ca5 to
92ba30b
Compare
c576842 to
7b48365
Compare
7b48365 to
8de3d74
Compare
augustepoiroux
added a commit
to augustepoiroux/LeanInteract
that referenced
this pull request
Oct 13, 2025
Add the following features: - Fine-grained data extraction for Lean declarations leanprover-community/repl#119 - Incremental elaboration leanprover-community/repl#110 - also fixes #6 - Parallel elaboration (through `set_option` support) - `set_option` support leanprover-community/repl#119 A few fixes: - leanprover-community/repl#108 - leanprover-community/repl#109 Add py.typed - #32 Breaking changes: - Support for Lean v4.7.0 is dropped
8de3d74 to
62f7f6f
Compare
62f7f6f to
30e8799
Compare
8290a60 to
bb76fa6
Compare
bb76fa6 to
4d97344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #66
The second problem mentioned in #66 is solved by this PR: all declarations preceding the sorries within a same REPL command are now correctly collected in the environment for ProofSnapshots. This issue is a major bottleneck when using the tactic mode on files where proofs depend on lemmas introduced in the same file (i.e. submitted in the same command in the REPL)
However, the initial problem in #66 is still not solved. Auxiliary declarations within the declaration itself are still not captured correctly. I attempted to replay these auxiliary declarations with limited success. Ideas to fix this are welcome.
Note: depends on #108