KBreadcrumbs visual tests in one file #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVelezLl
temporarily deployed
to
percy_tests
GitHub Actions
Inactive
Percy Visual Test ResultsPercy Dashboard: View Detailed Report Environment:
Instructions for Reviewers:
|
| Vue.component('KTextboxVisualTest', KTextboxVisualTest); | ||
| Vue.component('KTableVisualTest', KTableVisualTest); | ||
| Vue.component('CardsVisualTest', CardsVisualTest); | ||
| Vue.component('KBreadcrumbs', KBreadcrumbs); |
There was a problem hiding this comment.
Is this KBreadcrumbs import still needed now that we have the KBreadcrumbsVisualTest import, or can it be removed?
There was a problem hiding this comment.
Oh, it was never really necessary, removed! Thanks @LianaHarris360!
AlexVelezLl
had a problem deploying
to
percy_tests
GitHub Actions
Error
LianaHarris360
approved these changes
Oct 21, 2025
LianaHarris360
merged commit 724287a
into
learningequality:develop
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KBreadcrumbs visual tests in one file
Issue addressed
Closes #1098
Screenshots
Changelog