Skip to content

Filter out soft deleted users from lessons, quizzes and groups - #13806

Merged
nucleogenesis merged 1 commit into
learningequality:developfrom
AlexVelezLl:coach-broken-when-soft-delete-users
Oct 20, 2025
Merged

nucleogenesis merged 1 commit into
learningequality:developfrom
AlexVelezLl:coach-broken-when-soft-delete-users

Conversation

@AlexVelezLl

Copy link
Copy Markdown
Member

Summary

  • Filter out soft-deleted users from lessons, quizzes, and groups in the backend, to prevent the frontend from having problems when trying to access soft-deleted users' information.
  • Adds a filter argument to the annotate_array_aggregate method, to allow passing filters to the aggregate function.
    • This way, we can filter out soft-deleted users from the learners' list of lessons, quizzes, and groups.
  • Filter out soft-deleted users from the learners' lists of draft quizzes.
Grabacion.de.pantalla.2025-10-02.a.la.s.8.31.30.a.m.mov

References

Closes #13793.

Reviewer guidance

Follow the steps described on #13793.

@github-actions github-actions Bot added DEV: backend Python, databases, networking, filesystem... APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) labels Oct 2, 2025
@AlexVelezLl
AlexVelezLl requested a review from rtibbles October 2, 2025 13:41
@github-actions

github-actions Bot commented Oct 2, 2025 •

Copy link
Copy Markdown
Contributor

@AlexVelezLl
AlexVelezLl force-pushed the coach-broken-when-soft-delete-users branch from 06ee5a5 to 444f7ab Compare October 6, 2025 18:41
@nucleogenesis
nucleogenesis requested a review from pcenov October 13, 2025 19:24

@nucleogenesis nucleogenesis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense to me - I like the abstract Q() factory approach a lot that's really nice. I'll tag @pcenov in for some QA

@pcenov pcenov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexVelezLl, I confirm that #13793 is fixed.

@marcellamaki
marcellamaki requested a review from akolson October 15, 2025 14:19
@nucleogenesis
nucleogenesis merged commit a198532 into learningequality:develop Oct 20, 2025
52 checks passed
@AlexVelezLl
AlexVelezLl deleted the coach-broken-when-soft-delete-users branch October 22, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lesson and quizzes pages error out when there are soft deleted users

4 participants