Migrate setup_wizard to the new resource layer - #15182
Conversation
Build Artifacts
Smoke test screenshot |
fe7cda9 to
de6de4b
Compare
|
The red |
AlexVelezLl
left a comment
There was a problem hiding this comment.
Code changes look good, and smoke tests check out. It's ready for QA review, @rtibblesbot please add a QA steps section similar to the other migration PRs, thanks!
|
Added a QA steps section: seven flows covering the six renamed Class sweep: checked every open PR in the #15057 migration family for a missing QA-steps section. Three are open — #15163 already had one; #15183 (user_profile) did not, so it now has one too. #15144, #15155, #15162 and #15184 are merged and untouched. |
|
Removed the |
cancel/restart/clearAll are wire-identical to their _v2 pairs; every call site discards the resolved value, so the envelope-to-body change is invisible.
Both resources are plugin-local, so the recipe's in-place rewrite applies rather than a _v2 pair. The four methods now resolve with the response body, which LodJoinFacility destructures one level up.
No caller anywhere in kolibri/ or packages/, and a line-for-line duplicate of FacilityUserResource.listRemoteFacilityLearners, which ImportIndividualUserForm already calls. Its removal takes the last client/urls imports with it.
de6de4b to
2f23fb3
Compare
|
Rebased onto develop Re-verified after the rebase: Class sweep: checked all five open PRs in the #15057 migration family for the same staleness. #15163 and #15183 got the same request and are already on QA steps unchanged: none of the seven flows pins a peer Kolibri version, so nothing there was blocked on #15217. |
|
Restructured the body: Reviewer guidance now splits into @rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly |
pcenov
left a comment
There was a problem hiding this comment.
Thanks @AlexVelezLl @radinamatic and @rtibblesbot - no regressions observed while manually testing - good to go!
Summary
TaskResource.{cancel,restart,clearAll}call sites now use the_v2methods.SetupWizardResourceandFacilityImportResourceare plugin-local, so their four custom methods are rewritten in place ontorequestrather than paired with a_v2.LodJoinFacility.vuedestructures one level up;facilityadminsalready did.FacilityImportResource.listfacilitylearners— uncalled, and a duplicate ofFacilityUserResource.listRemoteFacilityLearners.References
Closes #15063. Recipe: #15057.
_v2methods: #15162.Reviewer guidance
Code review
For a developer reading the diff.
Resource.logError, whichaccessListEndpointnever called. A wrong password onSelectSuperAdminAccountForm.vue:175now emits aRequest error:group — confirm that is acceptable.useListconversion: the threeTaskResource.listsites aresetTimeoutpolling loops, anduseListwraps a singlelist()with no polling.QA steps
For a tester installing the build artifacts in a VM. No UI change — every screen below should behave as on develop. The wizard runs once per device, so each row needs a freshly installed VM; rows 2-6 need a second VM on the network running any released Kolibri with a facility on it.
AI usage
Used Claude Code to apply the shared migration recipe across the plugin and to write the resource spec covering the four rewritten methods. Verified with the setup_wizard Jest suite and prek.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-08-20 15:08 UTC