Skip to content

Conversation

Prashant-thakur77
Copy link
Contributor

Fixes #5411

Summary

Migrated 2 user action confirmation dialogs from Vuetify to KDS KModal.

After images for Desktop users:

Screenshot From 2025-10-02 21-59-02 Screenshot From 2025-10-02 21-59-21

After images for Mobile users:

Screenshot From 2025-10-01 18-38-14 Screenshot From 2025-10-01 18-38-31

References

• Parent issue: #5060

Reviewer guidance

Login as [email protected] with password a
Go to Administration > Users
Click Actions dropdown in the last column of the table
Click Deactivate
Click Delete

@MisRob
Copy link
Member

MisRob commented Oct 3, 2025

Thank you @Prashant-thakur77, we will assign a reviewer next week.

@MisRob MisRob changed the title [Remove Vuetify from Studio] Deactivate and delete confirmation dialogs in admin user actions #5411 [Remove Vuetify from Studio] Deactivate and delete confirmation dialogs in admin user actions Oct 6, 2025
@Prashant-thakur77
Copy link
Contributor Author

Prashant-thakur77 commented Oct 11, 2025

Hi @rtibbles @AlexVelezLl will update the pr as soon as changes in the below given pr gets merged as they are related to the issue faced here.learningequality/kolibri-design-system#1138 this is the concerned pr. ;)

@Prashant-thakur77 Prashant-thakur77 force-pushed the fix/remove-vuetify-user-dialogs-5411 branch from ab99e2c to c3b8282 Compare October 13, 2025 13:57
@Prashant-thakur77 Prashant-thakur77 force-pushed the fix/remove-vuetify-user-dialogs-5411 branch from 68bfdd5 to 00673ad Compare October 13, 2025 14:02
@Prashant-thakur77
Copy link
Contributor Author

Prashant-thakur77 commented Oct 13, 2025

Hi @AlexVelezLl ,

I've implemented the changes. Please review when you have time and let me know if there are any further adjustments needed. I'm happy to make any improvements you suggest.

@MisRob
Copy link
Member

MisRob commented Oct 13, 2025

Hi @Prashant-thakur77, I think we need to wait until we install the new KDS release with your update since you need it here too, right?

@Prashant-thakur77
Copy link
Contributor Author

Yes @MisRob

@MisRob
Copy link
Member

MisRob commented Oct 13, 2025

Okay, we will coordinate with you :) Then let the reviewers know after that's done, please - it's best to review after all is set up. We couldn't merge it anyway any time sooner. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Deactivate and delete confirmation dialogs in admin user actions

3 participants