[Remove Vuetify from Studio] Buttons in New folder and Trash #5428
+23
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace VBtn with KButton in trash confirmation dialog - Add proper spacing and alignment for buttons through Kbutton Group - Fix button wrapping on mobile screens with whitespace-nowrap - Apply code formatting standards
|
Thank you @Prashant-thakur77, we will assign a reviewer next week. |
|
hey @LianaHarris360 ,do tell if any changes are required.I will update accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5421
Summary
Replaced Vuetify VBtn elements with Kolibri Design System KButton elements in trash and folder creation modals. Added KButtonGroup containers to maintain proper element spacing and applied CSS to prevent button element wrapping on mobile screens.
Desktop Users
Successfully replaced Vuetify VBtn elements with Kolibri Design System KButton elements in trash and folder creation modals. Added KButtonGroup containers to maintain proper element spacing and applied CSS to prevent button element wrapping on mobile screens
Mobile Users
References
• Parent issue: #5060
Reviewer guidance
Login as [email protected] with password a
Go to Channels > Published Channel
Click Add > New folder and create the folder
Go back to the channel page
Select the folder
Click Remove
Open trash from the ... dropdown at the top of the page