-
Notifications
You must be signed in to change notification settings - Fork 231
[Remove Vuetify from Studio] Upload in progress and Save failed dialogs #5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Upload in progress and Save failed dialogs #5430
Conversation
Replace upload progress and save failed dialogs with KModal components. Maintains existing functionality and adds unit tests. Fixes learningequality#5422
@MisRob Please look into this PR |
Thanks @ANAS727189, we will assign a reviewer. |
...tion/contentcuration/frontend/channelEdit/components/edit/__tests__/editModal.kmodal.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ANAS727189! Good start so far! I have left a general comment in the implementation that we'll need to address. Thanks
@MisRob @akolson I rewrote the whole test file using VTL principles, loaded the actual EditModal instead of mocking and used KModal built-in buttons in EditModal. It got pretty complex with all the child components, but I fixed it and it passes all test cases. |
Thanks @ANAS727189, let's make exception and skip the unit test acceptance criteria in this PR. Thank you that you followed the issue requirements and sorry if it was a hassle - but as you mentioned too tests are very complex now and I think it would be difficult to take care of. We will try taking a different approach - more details above. |
@MisRob Thank you for the feedback! Just to clarify, should I remove the test file from this PR entirely? I can either:
Let me know your preference and I'll update accordingly. |
@ANAS727189 thanks for humble approach. Yes, let's remove the new spec file completely from this PR. But feel free to keep local copy - in case you'd like to work on the follow-up issue some time later, I'm glad to reserve it for you, so you can still use at least some of those pieces of code :) |
I only looked into the tests, and am happy to proceed now. @akolson after you've finished your review, feel free to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct to me! Thanks @ANAS727189
Replace upload progress and save failed dialogs with KModal components. Maintains existing functionality and adds unit tests.
Fixes #5422
How to test these changes:
[email protected]
with passworda
promptUploading: true
in EditModal.vue data()promptFailed: true
in EditModal.vue data()pnpm test -- editModal.kmodal.spec.js
Imp Note: The existing MessageDialog for "invalid nodes found" was intentionally left unchanged as it was not intended in this issue by issuer.
Summary
This PR migrates two specific dialogs in EditModal from Vuetify's MessageDialog to Kolibri Design System's KModal as part of the effort to remove Vuetify dependencies from Studio (#5060).
Changes made:
data-test="canceluploads"
attribute for testing compatibilityManual verification performed:
Screenshots:


…
References
…
Reviewer guidance
…