Skip to content

Update adaptation methods of middlewares in webpack4 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update adaptation methods of middlewares in webpack4 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e43dc8
update middlewares version for webpack4
Styx11 Apr 8, 2020
559c6ae
update devMiddleware adaptation methods
Styx11 Apr 8, 2020
d84c805
update hotMiddleware adaptation methods
Styx11 Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions middleware/devMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ export default (compiler, opts) => {
end: (content) => {
ctx.body = content
},
setHeader: (name, value) => {
ctx.set(name, value)
}
locals: ctx.state,
getHeader: ctx.get.bind(ctx),
setHeader: ctx.set.bind(ctx)
}, next)
}

Expand Down
9 changes: 7 additions & 2 deletions middleware/hotMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,14 @@ export default (compiler, opts) => {
const expressMiddleware = hotMiddleware(compiler, opts)
return async (ctx, next) => {
let stream = new PassThrough()
ctx.body = stream
// Set ctx.body in the middleware,
// otherwise the browser will download a unkown file
await expressMiddleware(ctx.req, {
write: stream.write.bind(stream),
end: stream.end.bind(stream),
write: content => {
if (!ctx.body) ctx.body = stream
return stream.write(content)
},
writeHead: (status, headers) => {
ctx.status = status
ctx.set(headers)
Expand Down
Loading