Skip to content

docs: add smart router subject area and two router maintainers - #3351

Merged
jeremyfowers merged 1 commit into
mainfrom
docs/maintainers-smart-router
Aug 26, 2026
Merged

docs: add smart router subject area and two router maintainers#3351
jeremyfowers merged 1 commit into
mainfrom
docs/maintainers-smart-router

Conversation

@ramkrishna2910

@ramkrishna2910 ramkrishna2910 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates the Maintainers table in docs/dev/contribute.md so the smart router has listed subject-area experts.

Scope

  • This PR addresses one clear issue or change.
  • I reviewed the full diff myself before submitting.
  • I removed unrelated local changes.
  • I kept refactoring separate unless it is required for this change.

One note on the diff size: both new usernames are 17 characters, which is wider than the previous 15-character name column, so every row is re-padded to keep the table aligned. That is why a 3-line content change shows as 18 insertions / 16 deletions. The only content changes are the three listed above; everything else is whitespace. A side effect of the re-pad is that @sawansri's row, which had extra trailing padding and was 24 characters wider than every other row, is now normalized with the rest.

Testing

  • Code builds without errors locally.
  • I tested this change locally.
  • I described the testing performed below.

Testing details:

No build — this PR changes one Markdown file and touches no code.

Verified locally:

  • Every row of the table is exactly 176 characters and parses as 3 cells, so the Markdown table is well formed and visually aligned.
  • New rows are inserted in the existing case-insensitive alphabetical order within the non-admin block: @eddierichter-amd between @bitgamma and @fl0rianr, @SlawomirNowaczyk between @siavashhub and @sofiageo.
  • Neither username was already present in the table.
  • Checked the pre-commit hooks that apply to a Markdown file by hand, since pre-commit is not installed in my environment: no trailing whitespace, file ends with a newline, LF line endings only.

Documentation

  • Documentation is affected and has been updated.

This PR is the documentation change.

Breaking Changes

  • This PR does not introduce breaking changes.

AI-assisted contribution

Please select one:

  • I used AI tools for this PR.

If AI tools were used:

  • I verified that I understand the changes.
  • I checked for hallucinated APIs, unrelated changes, and incorrect assumptions.

@fl0rianr @eddierichter-amd @SlawomirNowaczyk — flagging you since this lists you as reviewers for router work. Say so if you would rather not be on the hook for it, or if you want the subject area worded differently; @ramkrishna2910's row uses "smart router and orchestration" and I kept the shorter "smart router" for these three.

Add smart router to @fl0rianr and add rows for @eddierichter-amd and
@SlawomirNowaczyk, so the maintainers table reflects who actually
reviews routing-engine changes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ramkrishna2910 ramkrishna2910 added the documentation Improvements or additions to documentation label Aug 25, 2026
@fl0rianr
fl0rianr disabled auto-merge August 25, 2026 17:34

@fl0rianr fl0rianr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, by me, will be asked anyway.
Disabled auto merge to give the other two also a chance to respond.

@eddierichter-amd eddierichter-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with me!

@jeremyfowers
jeremyfowers added this pull request to the merge queue Aug 25, 2026
Merged via the queue into main with commit 303119c Aug 26, 2026
106 of 136 checks passed
@jeremyfowers
jeremyfowers deleted the docs/maintainers-smart-router branch August 26, 2026 03:15
fl0rianr pushed a commit that referenced this pull request Aug 26, 2026
Add smart router to @fl0rianr and add rows for @eddierichter-amd and
@SlawomirNowaczyk, so the maintainers table reflects who actually
reviews routing-engine changes.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants