Skip to content

Conversation

tdelmas
Copy link
Collaborator

@tdelmas tdelmas commented Nov 11, 2019

Uses prefers-color-scheme to display in dark mode when asked by the browser/OS (https://caniuse.com/#feat=prefers-color-scheme)

  • Graphs keeps a white background
  • Force a white background for sponsors logos
  • Remove the scrollbar when not needed for code

TODO:

  • move colors into vars
  • links are too dark
  • text is too bright
  • The blue of the Let's Encrypt logo (and in the "LINUX FOUNDATION COLLABORATIVE PROJECTS" header) is a little dark to show up against a black background
  • The brightness of the hero image feels a little jarring and out of place
  • Remove black lines between the sponsor logos
  • The "Donate" button at the bottom has black text
  • the black background the blue color of the "Donate" button feels over-saturated
  • text in the "Get Started" and "Sponsor" buttons inside the hero image is too light.

image

@tdelmas
Copy link
Collaborator Author

tdelmas commented Nov 13, 2019

Any argument for or against it? (related: https://community.letsencrypt.org/t/allow-users-to-select-dark-mode-theme/105987)

pre {
padding: 8px 12px;
overflow-x: scroll;
overflow-x: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this about?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an always-visible scrollbar in code content even when the window is large enough: https://letsencrypt.org/docs/revoking/
image
That scrollbar is useless, and it became worse in dark mode:
image

@bdaehlie
Copy link
Contributor

This seems like a nice addition so long as it looks just as good as the non-dark mode. Thanks!

@jsha
Copy link
Contributor

jsha commented Nov 13, 2019

I approve of adding dark mode in concept. I think this work-in-progress still needs a little work. Attached are a couple of screenshots from my Android device in dark mode.

Screenshot_20191113-110800
Screenshot_20191113-110805

Specific issues:

The blue of the Let's Encrypt logo (and in the "LINUX FOUNDATION COLLABORATIVE PROJECTS" header) is a little dark to show up against a black background. We should probably lighten that.

The brightness of the hero image feels a little jarring and out of place. Not sure how to fix this; probably it's best to just leave it alone.

The sponsor logos are on a white background. This is unavoidable because a lot of the sponsor logos would be unreadable on a black background. But it's awkward looking because there are black lines between the logos. I think we need to put all the logos in a big white box.

The "Donate" button at the botton has black text, while the rest of the text on the page has white text. Also, against the black background the blue color of the button feels over-saturated. Maybe match it to the blue used in hyperlinks?

@jsha
Copy link
Contributor

jsha commented Nov 13, 2019

Also, I think the text in the "Get Started" and "Sponsor" buttons inside the hero image is too light.

@tdelmas tdelmas mentioned this pull request Feb 15, 2020
@tdelmas tdelmas marked this pull request as draft April 8, 2020 20:18
@jimmywarting
Copy link

Bump

@bdaehlie
Copy link
Contributor

@scottmakestech How hard would this be to do with the current website?

@scottmakestech
Copy link
Collaborator

@scottmakestech How hard would this be to do with the current website?

I'll look into it. It seems doable. @bdaehlie

@bdaehlie
Copy link
Contributor

I wouldn't say it's a high priority, but if it's not too much work it would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants