Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Issue

Why is this change needed?

The team wants to assess the current state of filename conventions across the codebase by adding Biome's useFilenamingConvention rule configured for camelCase and PascalCase. This will help identify files that don't follow the desired naming conventions.

Changes Made

  • Added useFilenamingConvention rule to the shared Biome configuration (frontend/internal-packages/configs/biome.jsonc)
  • Configured the rule to enforce camelCase and PascalCase filename conventions
  • Set the rule level to error to make violations visible in lint output

Current Impact

Based on initial testing, the rule found 1 filename convention violation:

  • src/logos/XLogo.tsx in the @liam-hq/ui package (should be xLogo.tsx)

Review Checklist

⚠️ Important considerations for review:

  1. CI Impact: Verify this change won't break CI builds - the rule introduces new lint errors
  2. Rule Configuration: Confirm the Biome rule syntax and filenameCases options are correct
  3. Scope Assessment: The shared config affects all packages - there may be more violations than initially detected
  4. Alignment: Verify this matches the original request (assessment only, no fixes applied)

Note

As requested, lint errors are intentionally not fixed - this PR is solely for adding the rule to assess the current state of filename conventions in the codebase.

- Added useFilenamingConvention rule to Biome configuration
- Configured to enforce camelCase and PascalCase filename conventions
- Found 1 existing violation: src/logos/XLogo.tsx in @liam-hq/ui package
- Lint errors intentionally not fixed as requested

Co-Authored-By: [email protected] <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: e7ac382

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Sep 24, 2025 11:28am
liam-assets Ready Ready Preview Comment Sep 24, 2025 11:28am
liam-erd-sample Ready Ready Preview Comment Sep 24, 2025 11:28am
liam-storybook Ready Ready Preview Comment Sep 24, 2025 11:28am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Sep 24, 2025 11:28am

Copy link

supabase bot commented Sep 24, 2025

Updates to Preview Branch (devin/1758712807-add-filename-convention-rule) ↗︎

Deployments Status Updated
Database Wed, 24 Sep 2025 11:24:51 UTC
Services Wed, 24 Sep 2025 11:24:51 UTC
APIs Wed, 24 Sep 2025 11:24:51 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Wed, 24 Sep 2025 11:24:56 UTC
Migrations Wed, 24 Sep 2025 11:25:01 UTC
Seeding Wed, 24 Sep 2025 11:25:01 UTC
Edge Functions Wed, 24 Sep 2025 11:25:01 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant