Skip to content

Conversation

romainbellande
Copy link

Description

Technical test: Romain Bellande

  • add Dafalgan support
  • refactor overall code
  • add compare script
  • fix Dockerfile node version
  • update README.md
  • update tests
  • add .nvmrc file
  • add CI setup to ensure tests are passing before merging to master

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tests passed successfully

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pchab and others added 3 commits February 18, 2022 14:59
* add Dafalgan support
* refactor overall code
* add compare script
* fix Dockerfile node version
* update README.md
* update tests
* add .nvmrc file
@romainbellande
Copy link
Author

I spent about 2h30+ on this subject. I took some time to add some extra features for fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants