Technical test: Gérald Gallet #210
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inato Take-Home Test Specification
Description / Before reading the PR
This is my repo for the test project that you sent me. I spent 1h45 on this project.
I must precise that there has been an issue with what I did : I did my commit on a new branch under the main repository. When I tried to add them to this repo, I did a few bad moves and lost my commits.. I am sorry for this, and as a substitute, I will explain here what I did and the order in which I did it.
Methodology
updateBenefitValue
. I always kept the previous one, as deprecated, in case I wanted to go back.name
andbenefitMultipliersByExpiresIn
properties of the configexpires
property that I saw I needed.benefitAfterExpired
that I saw I needed