Skip to content

SDL3 upgrade #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

SDL3 upgrade #47

wants to merge 13 commits into from

Conversation

Berstanio
Copy link
Contributor

This PR removes the jampad dependency and uses the lwjgl3 SDL bindings instead.
Some classes from jampad have been moved over. I didn't saw the need for jampad being a seperate project anymore, as lwjgl3 provides the bindings now.
This PR depends on the 3.4.0-SNAPSHOT of lwjgl3.

By accident, I applied similar fixes as done in this pr: #38
This pr is based of this pr: #39

@MrStahlfelge
Copy link
Member

Is there a problem for Lwjgl2 projects having both Lwjgl3 and 2 in the classpath?

@PokeMMO
Copy link
Contributor

PokeMMO commented Jun 5, 2025

There's a problem for lwjgl2 projects having lwjgl2 on the classpath.

But yeah, you can't have both 2 and 3, it will cause issues.

@MrStahlfelge
Copy link
Member

MrStahlfelge commented Jun 5, 2025

Okay, I see the problem that people might not want to use Lwjgl3, but they can stick on older versions of libgdx and this library so this should not stop us.

However, I caused some conflicts by merging your other PR which I eventually tested and is needed to make the build succeed.

@MrStahlfelge
Copy link
Member

MrStahlfelge commented Jun 5, 2025

We should raise the version to 2.3.x (and make a 2.2.4 release) and add a new entry into the compatiblity matrix pointing out incompatibility with lwjgl2 projects.

@Berstanio Berstanio requested a review from a team as a code owner June 5, 2025 15:19
roboVMVersion = '2.3.19'
jamepadVersion = '2.26.5.0'
lwjgl3Version = '3.4.0-SNAPSHOT'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the snapshot version needed? Not good to have this library point to a snapshot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment yes, so I would only merge this after a stable lwjgl3 release exists.

Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably 'test/desktop' can be removed - it should not work any more?

'test/ios' does not compile, it seems like there is a dependency problem. Probably RoboVM needs to get updated to the version 1.13.x uses

@Berstanio
Copy link
Contributor Author

Probably 'test/desktop' can be removed - it should not work any more?

Yes, removed it.

'test/ios' does not compile, it seems like there is a dependency problem.

A class was apparantly moved, fixed the import. I also upgraded roboVM in one go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants