-
Notifications
You must be signed in to change notification settings - Fork 14
SDL3 upgrade #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SDL3 upgrade #47
Conversation
Is there a problem for Lwjgl2 projects having both Lwjgl3 and 2 in the classpath? |
There's a problem for lwjgl2 projects having lwjgl2 on the classpath. But yeah, you can't have both 2 and 3, it will cause issues. |
Okay, I see the problem that people might not want to use Lwjgl3, but they can stick on older versions of libgdx and this library so this should not stop us. However, I caused some conflicts by merging your other PR which I eventually tested and is needed to make the build succeed. |
We should raise the version to 2.3.x (and make a 2.2.4 release) and add a new entry into the compatiblity matrix pointing out incompatibility with lwjgl2 projects. |
2a3bf76
to
403e304
Compare
403e304
to
b12b760
Compare
roboVMVersion = '2.3.19' | ||
jamepadVersion = '2.26.5.0' | ||
lwjgl3Version = '3.4.0-SNAPSHOT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the snapshot version needed? Not good to have this library point to a snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment yes, so I would only merge this after a stable lwjgl3 release exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably 'test/desktop' can be removed - it should not work any more?
'test/ios' does not compile, it seems like there is a dependency problem. Probably RoboVM needs to get updated to the version 1.13.x uses
Yes, removed it.
A class was apparantly moved, fixed the import. I also upgraded roboVM in one go |
This PR removes the jampad dependency and uses the lwjgl3 SDL bindings instead.
Some classes from jampad have been moved over. I didn't saw the need for jampad being a seperate project anymore, as lwjgl3 provides the bindings now.
This PR depends on the
3.4.0-SNAPSHOT
of lwjgl3.By accident, I applied similar fixes as done in this pr: #38
This pr is based of this pr: #39