fix: preserve shortcut and window hook callback lifetimes - #82
Merged
Merged
Conversation
Clear shortcut callbacks after successful unregistration, outside the manager mutex. Retained handles can no longer invoke stale callbacks. Keep a local copy while invoking shortcuts and desktop window hooks so self-replacement or removal does not destroy executing captures. Add CTest coverage for self-replacement, hook removal, and retained handles.
lijy91
added a commit
to libnativeapi/nativeapi
that referenced
this pull request
Sep 25, 2026
…ters global shortcuts Merges libnativeapi/nativeapi-core#82 and the follow-ups: shortcut callbacks are guarded across threads, and Windows registers hotkeys on the thread that owns its message window, so global shortcuts work there at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unregistering a shortcut leaves its callback attached to retained handles. Callbacks and window hooks can also destroy their own captured state when they replace or clear themselves during invocation.
Clear shortcut callbacks after successful unregister, outside the manager mutex, and invoke a local copy of shortcut callbacks and desktop window hooks. The C ABI is unchanged.
Added regression tests for callback replacement, hook removal, and retained shortcuts after unregister.