Adding of TTL support for register of Responder and some clippy fixes #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This makes perfect sense, thanks. I'd love to see a doc comment for this function explaining DEFAULT_TTL and the unit of the Out of curiosity what prompted this addition for you? Did you want a longer or shorter TTL? Perhaps working around #27 ? |
willstott101
added a commit
that referenced
this pull request
Aug 24, 2025
…with_ttl Feature: Responder.register_with_ttl (supersedes: #59)
Contributor
|
Merged in #64 thanks! |
Contributor
|
Released in v0.9.2 |
Author
|
Sorry, I had a lot of work. To answer the question you had: I needed a shorter ttl for my project for testing purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to give a custom TTL for register per service.
And I added some fixes from clippy to remove unneeded warnings for certain imports and usage.