Feature/libris search ns #540
Merged
+66
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwahlin
force-pushed
the
feature/libris-search-ns
branch
from
9f80037 to
2aa76b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dedicated namespace for Libris Search terms.
TBD:
https://id.kb.se/ns/librissearch/.librissearch:definitions/sys/context/kbv.jsonld
Line 239 in b009a5e
Related XL adjustments: libris/librisxl#1660
These terms (e.g. itemHeldBy, hasInstanceType) are hard-coded in quite many places in lxlviewer so we should probably settle the prefix before changing anything there.
UPDATE
We should still decide on the namespace/prefix, however this is not a blocker with unprefixed terms being accepted in search, see libris/librisxl#1673.