Skip to content

Conversation

@mkunkacnc
Copy link
Contributor

So that they can be called where implemented. Dummy functions already exist for the OSes where they are not implemented.

@icculus
Copy link
Collaborator

icculus commented Jun 25, 2025

It seems like important functionality to just maybe do nothing on some platforms, though...

@sezero
Copy link
Collaborator

sezero commented Jun 28, 2025

I hate those commits with a message like "Update some_source.c" which doesn't say anything about what it does in the commit history. Can you please squash tour commits, and change the commit message to SDL_native_midi.h: Uncomment the Pause/Resume functions ?

@mkunkacnc mkunkacnc force-pushed the uncomment-pause-resume-functions branch from 1580925 to 07c928d Compare June 28, 2025 01:23
@icculus
Copy link
Collaborator

icculus commented Jun 28, 2025

I think for Haiku, we probably need to change virtual void Run() to:

  • Have a real time in startTime instead of B_NOW
  • If paused, SDL_Delay() a little and try again (or get fancy and have a Condition Variable so we sleep until stopped/unpaused).
  • When resumed, update startTime with the difference.
  • Only call SprayEvent when not paused.

But I don't have a convenient way to test this, so for now, let's leave it unimplemented, merge this PR, and wait for bug reports, which may never arrive.

@icculus icculus merged commit 2655f9a into libsdl-org:main Jun 28, 2025
3 checks passed
@mkunkacnc mkunkacnc deleted the uncomment-pause-resume-functions branch June 28, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants