Adding WebSocket (ws) URI #158
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for WebSocket URI schemes (ws:// and wss://) to the URI library. WebSocket URIs are defined in RFC 6455 and enable two-way communication between clients and servers, with wss:// providing SSL-secured connections.
- Implementation of
URI::wsandURI::wssmodules that inherit fromURI::httpandURI::httpsrespectively - Addition of comprehensive test coverage for WebSocket URI functionality
- Documentation updates to include WebSocket scheme descriptions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/URI/ws.pm | Implements the ws:// URI scheme by inheriting from URI::http |
| lib/URI/wss.pm | Implements the wss:// URI scheme by inheriting from URI::https |
| t/ws.t | Test suite covering WebSocket URI parsing, port handling, and scheme switching |
| lib/URI.pm | Documentation additions describing the ws:// and wss:// schemes |
| dist.ini | Adds "WebSocket" as an accepted spelling for documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| =head1 VERSION | ||
|
|
||
| Version 5.20 |
There was a problem hiding this comment.
The version in the documentation (5.20) does not match the version declared in the code (5.33). This inconsistency could confuse users.
| Version 5.20 | |
| Version 5.33 |
Copilot uses AI. Check for mistakes.
|
|
||
| =head1 VERSION | ||
|
|
||
| Version 5.20 |
There was a problem hiding this comment.
The version in the documentation (5.20) does not match the version declared in the code (5.33). This inconsistency could confuse users.
| Version 5.20 | |
| Version 5.33 |
Copilot uses AI. Check for mistakes.
|
|
||
| =head1 SEE ALSO | ||
|
|
||
| L<RFC 3507|http://tools.ietf.org/html/rfc3507> |
There was a problem hiding this comment.
The SEE ALSO section references RFC 3507, but WebSocket URIs are defined in RFC 6455 as mentioned in the description. RFC 3507 appears to be unrelated to WebSocket protocols.
| L<RFC 3507|http://tools.ietf.org/html/rfc3507> | |
| L<RFC 6455|http://tools.ietf.org/html/rfc6455> |
Copilot uses AI. Check for mistakes.
|
|
||
| =head1 SEE ALSO | ||
|
|
||
| L<RFC 3507|http://tools.ietf.org/html/rfc3507> |
There was a problem hiding this comment.
The SEE ALSO section references RFC 3507, but WebSocket URIs are defined in RFC 6455 as mentioned in the description. RFC 3507 appears to be unrelated to WebSocket protocols.
| L<RFC 3507|http://tools.ietf.org/html/rfc3507> | |
| L<RFC 6455|http://tools.ietf.org/html/rfc6455> |
Copilot uses AI. Check for mistakes.
Adding WebSocket scheme