forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 1
LPD-9465 - Allow users to save Custom Views #5216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
juanjofgliferay
wants to merge
24
commits into
liferay-frontend:master
from
juanjofgliferay:LPD-9465.v2
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
47488b6
LPD-9465 - Refactor. Move component to TS
juanjofgliferay ca3c5b3
LPD-9465 - Feat. Update model to store FDS Custom Views
juanjofgliferay 2a11ed9
LPD-9465 - Feat. Serialize snapshots
juanjofgliferay f4f766c
LPD-9465 - Feat. Add deeClone utility
juanjofgliferay 4375b89
LPD-9465 - Feat. Retrieve and handle user views/snapshots in FDS
juanjofgliferay dff3b58
LPD-9465 - Refactor. Remove Portalpreferences requests
juanjofgliferay 5aaf6b9
LPD-9465 - Refactor. Update taglib
juanjofgliferay f441e0b
LPD-9465 - Refactor. Update table to handle visible columns properly
juanjofgliferay 302dca8
LPD-9465 - Feat. Block ActiveViewSettings while working with User Vie…
juanjofgliferay 5ddc364
LPD-9465 - Refactor. Update exclude prop when applying snapshot
juanjofgliferay d65fc99
LPD-9465 - Refactor. Prevent filter mutation on activate/deactivate f…
juanjofgliferay 2f5a4ca
LPD-9465 - Feat. Include action that update filters without changing …
juanjofgliferay 79ba2ce
LPD-9465 - Feat. Display table after loading CX
juanjofgliferay 0e854d7
LPD-9465 - Add tests
juanjofgliferay 1b397ba
LPD-9465 - Add feature flag
juanjofgliferay 18513da
LPD-9465 - Feat. Add DSM UI to enable User Views
juanjofgliferay 6af2438
LPD-9465 - Refactor. Update FDS Sample
juanjofgliferay 1aa40c2
LPD-9465 - Refactor. Remove deprecation comment
juanjofgliferay 871c681
LPD-9465 - Refactor. Rename property
juanjofgliferay 9a392f7
LPD-9465 - Feat. Safe check
juanjofgliferay 829a07a
LPD-9465 - Feat. Ensure defaultSnapshot has an empty array if no filt…
juanjofgliferay e1bdc1f
LPD-9465 - SF
juanjofgliferay f288af6
LPD-9465 - Baseline
juanjofgliferay 2275e65
LPD-9465 - Refactor. Fix condition to avoid infinite spinner
juanjofgliferay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...tend-data-set-api/src/main/resources/com/liferay/frontend/data/set/serializer/packageinfo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| version 4.2.0 | ||
| version 4.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
String.valueOf()on a potentiallynullobject will result in the string literal"null". This is likely not what the frontend expects. It's better to pass the raw object fromproperties.get("label")toJSONUtil.put(), which will correctly serialize anullvalue to JSONnull.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Not sure. I'm using the same pattern used in other FDS places