Update remote hsmd to v23.08rc1

.dir-locals.el

@@ -4,4 +4,10 @@
             (c-basic-offset . 8)
             (tab-width . 8)
             ))
-)
+
+ (c++-mode . ((c-file-style . "linux")
+            (indent-tabs-mode . t)
+            (show-trailing-whitespace . t)
+            (c-basic-offset . 8)
+            (tab-width . 8)
+            )))

.github/scripts/setup.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 set -e
 export DEBIAN_FRONTEND=noninteractive
-export BITCOIN_VERSION=24.0.1
+export BITCOIN_VERSION=25.0
 export ELEMENTS_VERSION=22.0.2
 export RUST_VERSION=stable
 
@@ -15,6 +15,7 @@ sudo apt-get -qq install --no-install-recommends --allow-unauthenticated -yy \
      build-essential \
      clang \
      cppcheck \
+     curl \
      docbook-xml \
      eatmydata \
      gcc-aarch64-linux-gnu \
@@ -24,7 +25,6 @@ sudo apt-get -qq install --no-install-recommends --allow-unauthenticated -yy \
      git \
      libc6-dev-arm64-cross \
      libc6-dev-armhf-cross \
-     libgmp-dev \
      libpq-dev \
      libprotobuf-c-dev \
      libsqlite3-dev \
@@ -74,12 +74,30 @@ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- \
 
 # We also need a relatively recent protobuf-compiler, at least 3.12.0,
 # in order to support the experimental `optional` flag.
-PROTOC_VERSION=3.15.8
+
+# BUT WAIT!  Gentoo wants this to match the version from the Python protobuf,
+# which comes from the same tree.  Makes sense!
+
+# And
+#   grpcio-tools-1.54.0` requires `protobuf = ">=4.21.6,<5.0dev"`
+
+# Now, protoc changed to date-based releases, BUT Python protobuf
+# didn't, so Python protobuf 4.21.12 (in Ubuntu 23.04) corresponds to
+# protoc 21.12 (which, FYI, is packaged in Ubuntu as version 3.21.12).
+
+# So we're going to nail these versions as 21.12, which is what recent
+# Ubuntu has, and hopefully everyone else can get.  And this means that
+# When CI checks that no files have changed under regeneration, you won't
+# get a fail just because the dev's protoc is a different version.
+
+# Honorable mention go to Matt Whitlock for spelunking this horror with me!
+
+PROTOC_VERSION=21.12
 PB_REL="https://github.com/protocolbuffers/protobuf/releases"
 curl -LO $PB_REL/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip
-sudo unzip protoc-3.15.8-linux-x86_64.zip -d /usr/local/
+sudo unzip protoc-${PROTOC_VERSION}-linux-x86_64.zip -d /usr/local/
 sudo chmod a+x /usr/local/bin/protoc
 export PROTOC=/usr/local/bin/protoc
 export PATH=$PATH:/usr/local/bin
 env
-ls -lha /usr/local/bin
+ls -lha /usr/local/bin

.github/workflows/bsd.yml

@@ -11,18 +11,12 @@ jobs:
     runs-on: macos-10.15
     name: Build and test on FreeBSD
     timeout-minutes: 120
-    env:
-      DEVELOPER: 1
-      VALGRIND: 0
-      EXPERIMENTAL_FEATURES: 0
-      COMPAT: 1
     steps:
     - uses: actions/checkout@v2
     - name: Test in FreeBSD
       id: test
       uses: vmactions/[email protected]
       with:
-        envs: 'DEVELOPER VALGRIND EXPERIMENTAL_FEATURES COMPAT'
         usesh: true
         prepare: |
           pkg install -y \
@@ -36,7 +30,6 @@ jobs:
             autoconf \
             automake \
             libtool \
-            gmp \
             bash \
             gettext \
             sqlite3 \
@@ -46,12 +39,12 @@ jobs:
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain nightly-2021-08-3z1
 
           cd /tmp/ || exit 1
-          wget https://bitcoincore.org/bin/bitcoin-core-24.0.1/bitcoin-24.0.1-x86_64-linux-gnu.tar.gz
-          tar -xf bitcoin-24.0.1-x86_64-linux-gnu.tar.bz2
-          sudo mv bitcoin-24.0.1/bin/* /usr/local/bin
+          wget https://bitcoincore.org/bin/bitcoin-core-25.0/bitcoin-25.0-x86_64-linux-gnu.tar.gz
+          tar -xf bitcoin-25.0-x86_64-linux-gnu.tar.bz2
+          sudo mv bitcoin-25.0/bin/* /usr/local/bin
           rm -rf \
-            bitcoin-24.0.1-x86_64-linux-gnu.tar.gz \
-            bitcoin-24.0.1
+            bitcoin-25.0-x86_64-linux-gnu.tar.gz \
+            bitcoin-25.0
 
         run: |
           PATH=/root/.local/bin:$PATH
@@ -75,7 +68,8 @@ jobs:
           git config --global --add safe.directory `pwd`
           git submodule update --init --recursive
 
-          ./configure CC="$CC"
+          ./configure CC="$CC" --enable-developer --disable-valgrind
+
           cat config.vars
 
           cat << EOF > pytest.ini