-
Notifications
You must be signed in to change notification settings - Fork 112
Add onion mailbox for async recipients #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
👋 Thanks for assigning @tnull as a reviewer! |
996d102
to
f70cd08
Compare
8612c01
to
d9545a8
Compare
9818d0c
to
89d74d5
Compare
@@ -1491,6 +1497,11 @@ impl Node { | |||
Error::PersistenceFailed | |||
}) | |||
} | |||
|
|||
#[allow(missing_docs)] | |||
pub fn om_mailbox_is_empty(&self) -> bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to expose this to the integration test, but not sure how to do it without introducing an extra cfg flag
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase now.
8192f71
to
a971ee4
Compare
Rebased after merge of #621 |
a654b4e
to
2cac461
Compare
With the merge of lightningdevkit/rust-lightning#4049, it is now possible for a static invoice server to forward the invoice request to the recipient if they are online.
This introduces an in-memory mailbox to hold onion messages until the receiver comes online. This is required for async payment `held_htlc_available` messages. The mailbox is bounded by a maximum number of peers and a maximum number of messages per peer.
2cac461
to
ce98969
Compare
Adds functionality for LSPs to hold onion messages for their clients until they come back online.
Depends on lightningdevkit/rust-lightning#4046