Only use internal runtime in VssStore
#693
Open
+89
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @joostjager was un-assigned. |
tnull
force-pushed
the
2025-10-only-use-internal-runtime
branch
2 times, most recently
from
db2db6d to
6792792
Compare
|
IIRC the previous hang was reproducible locally. Is that still the case with the hang that this PR fixes? |
We previously attempted to drop the internal runtime from `VssStore`, resulting into blocking behavior. While we recently made changes that improved our situation (having VSS CI pass again pretty reliably), we just ran into yet another case where the VSS CI hung (cf. https://github.com/lightningdevkit/vss-server/actions/runs/19023212819/job/54322173817?pr=59). Here we attempt to restore even more of the original pre- ab3d78d / lightningdevkit#623 behavior to get rid of the reappearing blocking behavior, i.e., only use the internal runtime in `VssStore`.
tnull
force-pushed
the
2025-10-only-use-internal-runtime
branch
from
6792792 to
615c24a
Compare
Unfortunately it's not. And after kicking CI on lightningdevkit/vss-server#59, the flake went away (just as CI in generally now seemed to 'reliably' pass). I am worried though that it might reappear randomly in production. |
|
Is it reproducible by putting a loop around the test in Ci? To ensure that this PR really tackles the problem. |
tnull
force-pushed
the
2025-10-only-use-internal-runtime
branch
from
4f5a9bf to
7456b95
Compare
tnull
force-pushed
the
2025-10-only-use-internal-runtime
branch
2 times, most recently
from
51c92e2 to
e94fe69
Compare
tnull
force-pushed
the
2025-10-only-use-internal-runtime
branch
from
837f83f to
2911920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously attempted to drop the internal runtime from
VssStore, resulting into blocking behavior. While we recently made changes that improved our situation (having VSS CI pass again pretty reliably), we just ran into yet another case where the VSS CI hung (cf. https://github.com/lightningdevkit/vss-server/actions/runs/19023212819/job/54322173817?pr=59).Here we attempt to restore even more of the original pre- ab3d78d / #623 behavior to get rid of the reappearing blocking behavior, i.e., only use the internal runtime in
VssStore.