Skip to content

Fulfill hold times rustfmt #3937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented Jul 17, 2025

Split off from #3801 (request in #3801 (review))

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 17, 2025

👋 I see @valentinewallace was un-assigned.
If you'd like another reviewer assignment, please click here.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 84.97914% with 108 lines in your changes missing coverage. Please review.

Project coverage is 89.01%. Comparing base (cfa782d) to head (90965a9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 83.66% 67 Missing and 6 partials ⚠️
lightning/src/ln/channelmanager.rs 87.13% 33 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
+ Coverage   88.99%   89.01%   +0.01%     
==========================================
  Files         166      166              
  Lines      120874   121266     +392     
  Branches   120874   121266     +392     
==========================================
+ Hits       107577   107939     +362     
- Misses      10885    10923      +38     
+ Partials     2412     2404       -8     
Flag Coverage Δ
fuzz 22.53% <38.46%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnull tnull self-requested a review July 17, 2025 08:59
@joostjager joostjager removed the request for review from valentinewallace July 17, 2025 09:01
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the first commit matches cargo +1.63 fmt output and reviewed the second one.

LGTM. I'll go ahead and land this once CI passes as it's trivial and @valentinewallace and @TheBlueMatt had already ACKed this over at #3801.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@tnull tnull merged commit 033eda2 into lightningdevkit:main Jul 17, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants