Skip to content

Conversation

starius
Copy link
Contributor

@starius starius commented Sep 5, 2025

This PR is rebased #239

Bumps LND to latest master.

Updated Go to 1.24.6, updated golangci-lint to v2 and updated its config.

Needed by lightninglabs/taproot-assets#1748

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@starius starius mentioned this pull request Sep 5, 2025
Copy link
Contributor

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Roasbeef
Copy link
Member

Roasbeef commented Sep 6, 2025

Remove from draft? Does this replace #239?

@starius starius changed the title build: bump lnd [WIP] build: bump lnd Sep 6, 2025
@starius
Copy link
Contributor Author

starius commented Sep 6, 2025

I'm still working on it, updating Go, golangci-lint and its config. Added [WIP].
Yes, it replaces #239

starius and others added 3 commits September 5, 2025 21:58
v2 has a fix for missing dependency github.com/tdakkota/asciicheck which
break the build of v1 if GOPROXY is not used (where it is cached).
@starius starius changed the title [WIP] build: bump lnd build: bump lnd Sep 6, 2025
@starius starius marked this pull request as ready for review September 6, 2025 01:15
@starius
Copy link
Contributor Author

starius commented Sep 6, 2025

It is ready!

I updated Go to 1.24.6, updated golangci-lint to v2 and updated its config.

Also tested with Loop - it passes all the tests.

@GeorgeTsagk GeorgeTsagk merged commit 548fa9b into lightninglabs:master Sep 8, 2025
1 check passed
@starius starius deleted the bump-lnd branch September 9, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants