staticaddr: signet testing fixes

[hieblmi]

• fixes a display issue with the quoted receive amount
• fixes auto-selection of expired deposits

[gemini-code-assist]

Summary of Changes

Hello @hieblmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a display inconsistency within the loop command-line tool, specifically concerning how quoted receive amounts are presented to the user. By refining the logic for determining the amount to display, it ensures that the output accurately reflects either the explicitly requested amount or the system-quoted amount when no specific request was made, leading to a clearer user experience.

Highlights

• Display Logic Refinement: Corrected an issue in the printQuoteInResp function where the displayed receive amount was inconsistent. The logic now prioritizes the requested amount (req.Amt) but falls back to the quoted amount (resp.QuotedAmt) if the requested amount is zero, ensuring accurate display for both 'Previously deposited on-chain' and 'Send on-chain' scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a display issue in the loop-in quote functionality. The change ensures that when a quote is requested using deposit outpoints without specifying an amount, the correct quoted amount from the server response is used for displaying the 'Receive off-chain' value. This prevents showing a negative amount. The implementation is clean, introducing a local variable to hold the correct amount and using it consistently, which also simplifies the printing logic. The change also includes a minor grammatical fix in a comment.

[sputn1ck]

LGTM! thanks

[starius]

LGTM!
I tested it in regtest. Works great!

$ loop static in 800000
Send on-chain:                             800000 sat
Receive off-chain:                         796723 sat
Estimated total fee:                         3277 sat

CONTINUE SWAP? (y/n):