price oracle: add intent, optional peer_id and metadata to QueryAssetRates RPC
#1677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17107029065Details
💛 - Coveralls |
guggero
force-pushed
the
price-oracle-metadata
branch
from
cacf233 to
babbbfa
Compare
|
I think change log changes for this PR have been merged already: #1679 (comment) |
|
@guggero the combination of the |
guggero
force-pushed
the
price-oracle-metadata
branch
from
babbbfa to
da60f26
Compare
|
Added an end-to-end test that verifies all calls, taking out of draft. |
|
@ffranr: review reminder |
jtobin
approved these changes
Aug 20, 2025
To align the interface method names more with the actual RPC calls, we replace the terms ask and bid with sale, purchase respectively.
This commit adds three new fields to the price oracle's QueryAssetRates RPC call: The intent behind the call, the peer at the opposite side of the transaction and user-defined metadata. To understand the role of those fields and how they can help the price oracle to decide what price rate to return, we also add a sequence diagram with the full price oracle interaction to the RFQ document.
This commit adds the price oracle metadata field to the buy and sell request messages that are sent over the p2p network between participants. We'll actually hook up things to populate the value in a later commit.
This informs the price oracle about the intent and other context behind a call to its QueryAssetRate RPC method.
To improve privacy when using a public or untrusted third-party price oracle, we no longer send a price hint by default. We also make sharing the peer's identity public key with the price oracle opt-in.
guggero
force-pushed
the
price-oracle-metadata
branch
from
da60f26 to
3294fc1
Compare
|
Rebased. |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1159 (replaces #1161).
cc @lukegao209 and @bitcoin-coder-bob, does this look like what you had in mind?
The metadata field can be used to send any JSON or other custom data (e.g. user information or authentication data) to the price oracle for any payment or invoice creation request.
The two new diagrams now show how the price oracle is called and with what parameters:
https://github.com/lightninglabs/taproot-assets/blob/cacf2339ff448bd04b7fdde4dcb713d196a75d4a/docs/rfq-and-decimal-display.md#price-oracle-interaction
See this to get an explanation for the intent values:
taproot-assets/taprpc/priceoraclerpc/price_oracle.proto
Line 31 in cacf233