Skip to content

Conversation

guggero
Copy link
Contributor

@guggero guggero commented Jul 31, 2025

Depends on btcsuite/btcwallet#1022 and then lightningnetwork/lnd#10119 which will hopefully make it into lnd v0.19.3-beta.

Created this itest to reproduce lightninglabs/lightning-terminal#1123.
Further investigation then lead to the creation of this bug report issue: lightningnetwork/lnd#10120

So this test will not succeed until lightningnetwork/lnd#10120 is fixed. But putting up the PR as a draft as we should aim to fix that issue and then have these tests run in the CI by default.

@coveralls
Copy link

coveralls commented Jul 31, 2025

Pull Request Test Coverage Report for Build 17131700681

Details

  • 45 of 45 (100.0%) changed or added relevant lines in 2 files are covered.
  • 377 unchanged lines in 31 files lost coverage.
  • Overall coverage decreased (-0.3%) to 56.363%

Files with Coverage Reduction New Missed Lines %
commitment/tap.go 2 84.74%
fn/iter.go 2 62.07%
internal/test/helpers.go 2 87.41%
tapdb/migrations.go 2 76.06%
tapdb/sqlc/transfers.sql.go 2 82.65%
tapdb/universe_federation.go 2 88.55%
universe/archive.go 2 79.29%
itest/assertions.go 3 89.08%
proof/courier.go 3 79.53%
tapchannel/aux_leaf_signer.go 3 43.43%
Totals Coverage Status
Change from base Build 17124421589: -0.3%
Covered Lines: 60539
Relevant Lines: 107409

💛 - Coveralls

@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Jul 31, 2025
@levmi levmi moved this from 👀 In review to 🏗 In progress in Taproot-Assets Project Board Jul 31, 2025
@guggero guggero force-pushed the itest-remote-signer branch 2 times, most recently from e62df0f to f200946 Compare August 7, 2025 07:26
@guggero guggero marked this pull request as ready for review August 7, 2025 07:30
@guggero
Copy link
Contributor Author

guggero commented Aug 7, 2025

With lnd v0.19.3-beta.rc1 out, this is now out of draft.

@guggero guggero requested review from ffranr and GeorgeTsagk August 7, 2025 07:30
@guggero guggero moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Aug 7, 2025
@guggero guggero force-pushed the itest-remote-signer branch 3 times, most recently from f1b456f to 1e4f9ea Compare August 21, 2025 07:25
@guggero guggero requested review from jtobin and removed request for ffranr August 21, 2025 07:25
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

This commit adds a new flag to the integration test suite that starts
the single lnd node (alice) either in normal or in remote-signing mode.
In remote-signing mode, alice is actually a watch-only node that is
connected to a seconardy signer node over RPC.
To make sure `tapd` works when the connected `lnd` node is running in
remote-signing mode, we add a new CI target that runs all integration
tests in that mode.
@guggero guggero force-pushed the itest-remote-signer branch from 1e4f9ea to 1e2cb4a Compare August 21, 2025 15:35
@lightninglabs-deploy
Copy link

@GeorgeTsagk: review reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

5 participants