universe/supplycommit: add done channel to enable sync processing of events #1729
+306
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
sync-supply-commit
branch
from
14c2562 to
d701373
Compare
Pull Request Test Coverage Report for Build 16980644335Details
💛 - Coveralls |
guggero
approved these changes
Aug 14, 2025
This interface wraps the existing SupplyUpdateEvent interface with two methods: one to signal that the event has been processed, and the other to wait on this. We'll use this to implement a sync callback/event to allow callers to block until the event has been written to disk.
In this commit, we start to use the new interface, and signal done after an error or succesful write.
…anager This'll be used by callers to make sure that they only exit once the new pending update has been written to disk.
Roasbeef
force-pushed
the
sync-supply-commit
branch
from
d701373 to
7438d5c
Compare
|
Addressed comments in a new push. |
|
Merging so I can rebase on top of: #1675. |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add a new done channel to the events that queue up a new supply commit update on disk. Callers can then call
WaitForDoneto block until the event has been written to disk. This addresses a gap that could cause lost events when sent by other sub systems.