makefile: targets for itest w/ race detection #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds three targets for race detection: - `build-itest-race` builds itest btcd and itest lnd, but only the latter with the `race` flag set. - `itest-race-only` runs itests with the `race` flag set. - `itest-race` runs `build-itest-race` and `itest-race-only` consecutively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three targets for race detection:
build-itest-racebuilds itest btcd and itest lnd, but only thelatter with the
raceflag set.itest-race-onlyruns itests with theraceflag set.itest-racerunsbuild-itest-raceanditest-race-onlyconsecutively.
It is uncertain whether we need to build lnd with the
raceflag set. Race conditions should already have been found during CI of lnd itself. This would only detect edge cases where the race condition is triggerd by something in tapd.Running itests with this setup results in a context timeout. It seems to be sensitive to that. So before we can do proper race detection, we need to fix that.