Skip to content

fn: fix TestWriteFile when running as root #10186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fn: fix TestWriteFile when running as root #10186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions fn/io_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package fn

import (
"os"
"syscall"
"testing"

"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -35,6 +36,12 @@ func TestWriteFile(t *testing.T) {
err = os.Chmod(filename, 0444)
require.NoError(t, err, "couldn't change file to read-only")

// Root can bypass read-only file mode, so change the file owner.
if syscall.Geteuid() == 0 {
err = os.Chown(filename, 1000, 1000)
require.NoError(t, err, "couldn't chown the file")
}

// Write must fail and keep the file.
err = WriteFile(filename, []byte(data2), 0644)
require.Error(t, err, "shouldn't write a read-only file")
Expand Down Expand Up @@ -65,6 +72,12 @@ func TestWriteFileRemove(t *testing.T) {
err = os.Chmod(filename, 0444)
require.NoError(t, err, "couldn't change file to read-only")

// Root can bypass read-only file mode, so change the file owner.
if syscall.Geteuid() == 0 {
err = os.Chown(filename, 1000, 1000)
require.NoError(t, err, "couldn't chown the file")
}

// Write must fail and remove the file.
err = WriteFileRemove(filename, []byte(data2), 0644)
require.Error(t, err, "shouldn't write a read-only file")
Expand Down
Loading