Skip to content

LCORE-2922: Bump-up xxhash - #2455

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-2922-bump-up-xxhash
Aug 17, 2026
Merged

LCORE-2922: Bump-up xxhash#2455
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-2922-bump-up-xxhash

Conversation

@tisnik

@tisnik tisnik commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Description

LCORE-2922: Bump-up xxhash

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-2922

Summary by CodeRabbit

  • Chores
    • Updated the bundled xxhash dependency to version 3.8.1.
    • Refreshed its integrity verification hashes.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0e589394-ee49-4e58-bc82-806c1e95d669

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1da38 and 1a3206c.

📒 Files selected for processing (1)
  • .konflux/requirements.hashes.wheel.txt

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (23)
  • GitHub Check: check
  • GitHub Check: E2E Tests for Lightspeed Evaluation job
  • GitHub Check: E2E: server / ci / tls
  • GitHub Check: E2E: library / ci / mcp
  • GitHub Check: E2E: library / ci / default
  • GitHub Check: E2E: library / ci / authorized
  • GitHub Check: E2E: server / ci / authorized
  • GitHub Check: E2E: server / ci / rbac
  • GitHub Check: E2E: server / ci / other
  • GitHub Check: E2E: server / ci / mcp
  • GitHub Check: E2E: library / ci / other
  • GitHub Check: E2E: library / ci / skills
  • GitHub Check: E2E: server / ci / skills
  • GitHub Check: E2E: server / ci / default
  • GitHub Check: E2E: library / ci / rbac
  • GitHub Check: build-pr
  • GitHub Check: Pylinter
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request
🔇 Additional comments (2)
.konflux/requirements.hashes.wheel.txt (2)

431-432: 🗄️ Data Integrity & Integration

Keep the hashes for the RHOAI index.

.konflux/requirements.hashes.wheel.txt is generated from https://console.redhat.com/api/pypi/public-rhai/rhoai/3.3/cpu-ubi9/simple/, not PyPI. PyPI hashes are not applicable to this file.

			> Likely an incorrect or invalid review comment.

430-430: 🗄️ Data Integrity & Integration

Keep the separate xxhash pins.

.konflux/requirements.hashes.wheel.txt uses RHOAI wheels and correctly pins 3.8.1. uv.lock uses PyPI and correctly pins 4.0.0.

			> Likely an incorrect or invalid review comment.

Walkthrough

The pinned xxhash wheel dependency changes from 3.8.0 to 3.8.1. Both corresponding SHA-256 hashes are replaced.

Changes

Dependency update

Layer / File(s) Summary
Update xxhash wheel pin
.konflux/requirements.hashes.wheel.txt
The file pins xxhash to 3.8.1 and updates both package hashes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1a320

This PR updates xxhash wheel hashes while preserving the RHOAI index hashes and separate environment-specific pins; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: radofuchs

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the xxhash dependency update and links it to the relevant issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity ✅ Passed PASS: The diff changes only the pinned xxhash version and hashes in one requirements file; no source algorithms, loops, API calls, caches, or list operations changed.
Security And Secret Handling ✅ Passed The commit changes only xxhash 3.8.0 to 3.8.1 and two SHA-256 hashes in a requirements manifest; it adds no secrets, endpoints, code, logs, or Kubernetes resources.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tisnik
tisnik merged commit 972c52e into lightspeed-core:main Aug 17, 2026
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant