Skip to content

RSPEED-3444: fix REST API metrics middleware route discovery and root_path handling - #2703

Merged
tisnik merged 1 commit into
lightspeed-core:release/0.6from
anik120:backport-rspeed-3444
Sep 18, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:release/0.6from
anik120:backport-rspeed-3444

Conversation

@anik120

@anik120 anik120 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 694e5f68-162b-4244-ac2f-15facd4ccd61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@anik120

anik120 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

cc: @tisnik

@anik120
anik120 force-pushed the backport-rspeed-3444 branch from 12f8262 to 1758f34 Compare September 15, 2026 15:32
@anik120

anik120 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

Wow CI is very red but looking at all the recent 0.6 merges (eg #2656) I'm guessing we're just letting it be

I can't tell why e2e borks after 5s immediately either, it just has

Run echo "=== Configuration Summary ==="
=== Configuration Summary ===
Deployment mode: library
Environment: ci
E2E shard (Makefile test-e2e-tagged): not @skip and (@cfg_rh_identity or @cfg_negative or @cfg_byok_pdf or @cfg_degraded or @cfg_unified)
Source config: tests/e2e/configs/run-ci.yaml

=== Configuration Preview ===
Providers: 19
Models: 3

=== lightspeed-stack.yaml ===

and no other info

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit 6121bc8 into lightspeed-core:release/0.6 Sep 18, 2026
24 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants