Skip to content

Support bitwise operations in luaL_loadbuffer_proto #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Jun 3, 2025

No description provided.

@ligurio ligurio force-pushed the ligurio/gh-xxxx-support-bitwise-operations branch 4 times, most recently from e1d1dde to 85d173c Compare June 10, 2025 07:47
@ligurio ligurio requested a review from Buristan July 14, 2025 09:40
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch-set!
I'll proceed with the review per-patch below.


[PATCH 1/3] extra: add more errors found in PUC Rio Lua

LGTM.

Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PATCH 2/3] tests/capi: support floor division operation

Thanks for the patch!
Please consider my comment below.

Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PATCH 3/3] tests/capi: support bitwise operations in luaL_loadbuffer_proto

Thanks for the patch!
Please consider my comment below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 17, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-support-bitwise-operations branch from 85d173c to c410a55 Compare July 22, 2025 14:38
@ligurio ligurio assigned Buristan and unassigned ligurio Jul 22, 2025
@ligurio ligurio requested a review from Buristan July 22, 2025 14:38
@Buristan Buristan assigned ligurio and unassigned Buristan Jul 24, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-support-bitwise-operations branch from c410a55 to e0dab88 Compare July 28, 2025 19:09
@ligurio ligurio assigned Buristan and unassigned ligurio Jul 28, 2025
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the fixes!
LGTM, after fixing 2 nits below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 29, 2025
ligurio added 3 commits July 29, 2025 14:21
The PUC Rio Lua 5.3 has introduced a floor division (//)
operation. It is a division that rounds the quotient towards
minus infinity, that is, the floor of the division of its operands.
The patch adds support of the aforementioned operation to a
protobuf schema, serializer and preamble.
The `bit32` library has been deprecated in PUC Rio Lua 5.3 [1].
Missed bitwise functions have been replaced by appropriate bitwise
operations [2]. The patch adds support of bitwise operations to
the test `luaL_loadbuffer_proto`.

1. https://www.lua.org/manual/5.3/manual.html#8.2
2. https://www.lua.org/manual/5.3/manual.html#3.4.2
@ligurio ligurio force-pushed the ligurio/gh-xxxx-support-bitwise-operations branch from e0dab88 to 82f87c0 Compare July 29, 2025 11:25
@ligurio ligurio assigned Buristan and unassigned ligurio Jul 29, 2025
@Buristan
Copy link
Collaborator

Sergey,
Thanks for the fixes!
LGTM!

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 30, 2025
@ligurio ligurio merged commit 502a244 into master Jul 30, 2025
12 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-support-bitwise-operations branch July 30, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants