-
Notifications
You must be signed in to change notification settings - Fork 3
Support bitwise operations in luaL_loadbuffer_proto #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1d1dde
to
85d173c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sergey!
Thanks for the patch-set!
I'll proceed with the review per-patch below.
[PATCH 1/3] extra: add more errors found in PUC Rio Lua
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PATCH 2/3] tests/capi: support floor division operation
Thanks for the patch!
Please consider my comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PATCH 3/3] tests/capi: support bitwise operations in luaL_loadbuffer_proto
Thanks for the patch!
Please consider my comment below.
85d173c
to
c410a55
Compare
c410a55
to
e0dab88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sergey!
Thanks for the fixes!
LGTM, after fixing 2 nits below.
The PUC Rio Lua 5.3 has introduced a floor division (//) operation. It is a division that rounds the quotient towards minus infinity, that is, the floor of the division of its operands. The patch adds support of the aforementioned operation to a protobuf schema, serializer and preamble.
The `bit32` library has been deprecated in PUC Rio Lua 5.3 [1]. Missed bitwise functions have been replaced by appropriate bitwise operations [2]. The patch adds support of bitwise operations to the test `luaL_loadbuffer_proto`. 1. https://www.lua.org/manual/5.3/manual.html#8.2 2. https://www.lua.org/manual/5.3/manual.html#3.4.2
e0dab88
to
82f87c0
Compare
Sergey, |
No description provided.