Skip to content

tests/lapi: table tests #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

tests/lapi: table tests #142

merged 1 commit into from
Jul 28, 2025

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Jul 3, 2025

No description provided.

@ligurio ligurio marked this pull request as draft July 3, 2025 11:39
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-table branch 4 times, most recently from 4b7cde9 to be50402 Compare July 14, 2025 19:43
@ligurio ligurio marked this pull request as ready for review July 14, 2025 19:48
@ligurio ligurio requested a review from Buristan July 14, 2025 19:48
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-table branch 3 times, most recently from 2791879 to 259b7c2 Compare July 15, 2025 10:06
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch!
Please consider my comments below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 17, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-table branch 4 times, most recently from babbc83 to 98a0fe3 Compare July 24, 2025 12:10
@ligurio ligurio assigned Buristan and unassigned ligurio Jul 24, 2025
@ligurio ligurio requested a review from Buristan July 24, 2025 12:10
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-table branch 3 times, most recently from 244864b to 9ecb921 Compare July 24, 2025 15:30
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the fixes!
Please consider bunch of nits below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 25, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-table branch from 9ecb921 to 88d4268 Compare July 25, 2025 10:16
The patch adds a fuzzing tests for Lua table functions except the
the function `table.unpack`, it will be tested by
`builtin_unpack_test.lua`.
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-table branch from 88d4268 to cd6f54b Compare July 25, 2025 10:17
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sergey,
Thanks for the fixes!
LGTM!

ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jul 28, 2025
@ligurio ligurio merged commit ee032e7 into master Jul 28, 2025
12 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-lapi-table branch July 28, 2025 11:15
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants