Skip to content

tests/lapi: add utf8 tests #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

tests/lapi: add utf8 tests #143

merged 1 commit into from
Jul 25, 2025

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Jul 3, 2025

No description provided.

@ligurio ligurio marked this pull request as draft July 3, 2025 12:11
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-utf8 branch 2 times, most recently from 8a61cf7 to 4171260 Compare July 8, 2025 08:48
@ligurio ligurio marked this pull request as ready for review July 8, 2025 08:51
@ligurio ligurio added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 8, 2025
@ligurio ligurio requested a review from Buristan July 14, 2025 09:40
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the patch!
LGTM, with a minor comments below.

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 15, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-utf8 branch from 4171260 to 9f7f372 Compare July 21, 2025 15:37
@ligurio ligurio requested a review from Buristan July 22, 2025 12:20
@ligurio ligurio assigned Buristan and unassigned ligurio Jul 22, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-utf8 branch 3 times, most recently from 4392c48 to ece78f0 Compare July 22, 2025 14:51
Copy link
Collaborator

@Buristan Buristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sergey!
Thanks for the fixes!
LGTM!

@Buristan Buristan assigned ligurio and unassigned Buristan Jul 25, 2025
@ligurio ligurio force-pushed the ligurio/gh-xxxx-lapi-utf8 branch from ece78f0 to 9ba26d5 Compare July 25, 2025 10:01
@ligurio ligurio merged commit fb7a2e9 into master Jul 25, 2025
12 checks passed
@ligurio ligurio deleted the ligurio/gh-xxxx-lapi-utf8 branch July 25, 2025 10:49
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jul 25, 2025
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jul 25, 2025
ligurio added a commit to ligurio/lua-c-api-corpus that referenced this pull request Jul 28, 2025
ligurio added a commit that referenced this pull request Jul 28, 2025
The function `utf8.offset()` raises, the patch wraps it by `xpcall()`
and suppress errors with message "initial position is a
continuation byte".

Follows up #143
ligurio added a commit that referenced this pull request Jul 28, 2025
The function `utf8.offset()` raises, the patch wraps it by `xpcall()`
and suppress errors with message "initial position is a
continuation byte".

Follows up #143
ligurio added a commit that referenced this pull request Jul 28, 2025
The function `utf8.offset()` raises, the patch wraps it by `xpcall()`
and suppress errors with message "initial position is a
continuation byte".

Follows up #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants