-
Notifications
You must be signed in to change notification settings - Fork 3
tests/lapi: add debug tests #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d90d076
to
33941a1
Compare
33941a1
to
fb812c7
Compare
fb812c7
to
775479f
Compare
Follows up ligurio/lua-c-api-tests#144 Related to tarantool/tarantool#11470
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Sergey!
Thanks for the patch!
Please consider my comments below.
Maybe it is worth joining the tests into a single one, since the hook functionality and TestOneInput wrapper are the same for all tests.
65d2ef2
to
08949ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sergey,
Thanks for the fixes!
LGTM!
Follows up ligurio/lua-c-api-tests#144 Related to tarantool/tarantool#11470
The commit adds tests for the following functions in debug library: `debug.getlocal()`, `debug.getupvalue()` and `debug.getinfo()`.
08949ae
to
492a73e
Compare
Follows up ligurio/lua-c-api-tests#144 Related to tarantool/tarantool#11470
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
Since commit 8e35f0c ("cmake: bump luzer version") `fdp:oneof()` in luzer API returns two values: a table's item and it's index. This breaks test `debug_torture_test.lua` with a message below > bad argument #2 to 'insert' (number expected, got string) because `fdp:one()` passed to `table.insert()` makes a call with three arguments: table, hook mask ("string") and index ("number"), while `table.insert()` with three arguments expects table, `pos` ("number"), and a value (any type). Follows up #144
No description provided.