New finalScalePosition Param - #86
Closed
LiamBateman wants to merge 1 commit into
Closed
LiamBateman wants to merge 1 commit into
LiamBateman wants to merge 1 commit into
Conversation
likashefqet
reviewed
Jul 10, 2025
likashefqet
left a comment
likashefqet
left a comment
Owner
There was a problem hiding this comment.
PR looks fine, although I would suggest passing an animated scale value as a prop to the ImageZoom/Zoomable component for smoother animations that update in real time instead of waiting for the gesture to end. This value will reflect the component鈥檚 current scale and can be used to drive animations of other elements seamlessly during gestures.
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use the onPinchEnd event as so:
onPinchEnd={(e) => console.log('onPinchEnd', e)}
It returns only the scale change, not the new scale. I propose to include another parameter which returns the current scale as well.
This is super useful for matching other UI elements that may need to move in time with the image being scaled.
I've proposed the name 'finalScalePosition'.
(#83)