Add runtime option for the docker container driver #3896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to select between "runc" and "runv", etc. Validation is done later (by the driver), if actually used. Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
reviewed
Aug 22, 2025
| @@ -107,14 +107,19 @@ type User struct { | |||
| } | |||
|
|
|||
| type VMOpts struct { | |||
| QEMU QEMUOpts `yaml:"qemu,omitempty" json:"qemu,omitempty"` | |||
| QEMU QEMUOpts `yaml:"qemu,omitempty" json:"qemu,omitempty"` | |||
| Docker DockerOpts `yaml:"docker,omitempty" json:"docker,omitempty"` | |||
| } | |||
There was a problem hiding this comment.
This contradicts to the current VM driver design.
Driver details must not be put to the yaml definition
There was a problem hiding this comment.
Do you have a pointer to the new "opts"?
Is that somewhere in the mega-PR perhaps
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay, so there is no actual code for it yet
AkihiroSuda
reviewed
Aug 22, 2025
| @@ -107,14 +107,19 @@ type User struct { | |||
| } | |||
|
|
|||
| type VMOpts struct { | |||
There was a problem hiding this comment.
Suggested change
| type VMOpts struct { | |
| type VMOpts map[string]any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to select between "runc" and "runv", etc.
Validation is done later (by the driver), if actually used.
Required by: (currently hardcoded)