Skip to content

Conversation

afbjorklund
Copy link
Member

@afbjorklund afbjorklund commented Sep 7, 2025

Restores the functionality:
commit df5e35a

That was reverted (again):
commit 2076ff1

func (l *LimaWslDriver) SSHAddress(_ context.Context) (string, error) {
	return "127.0.0.1", nil
}

@afbjorklund
Copy link
Member Author

afbjorklund commented Sep 7, 2025

It seems like InspectStatus is never called, and it expects the new SSHAddress to do this instead?

This broke the drivers, because they now don't get the dynamic ssh address even after running...

@unsuman

@unsuman
Copy link
Contributor

unsuman commented Sep 7, 2025

It seems like InspectStatus is never called, and it expects the new SSHAddress to do this instead?

driver.InspectStatus() is called in:

inspectStatus(ctx, instDir, inst, y)

This broke the drivers, because they now don't get the dynamic ssh address even after running...

Drivers? It is only applicable to wsl2 afaik.

@afbjorklund
Copy link
Member Author

Drivers? It is only applicable to wsl2 afaik.

I was referring to the three container drivers

@@ -229,3 +229,27 @@ func getWslStatus(instName string) (string, error) {

return instState, nil
}

func getSSHAddress(ctx context.Context, instName string) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be called from the wsl_driver_windows.go too?

func (l *LimaWslDriver) SSHAddress(ctx context.Context) (string, error) {
	return getSSHAddress(ctx, l.Instance.Name)
}

Copy link
Member Author

@afbjorklund afbjorklund Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it will fail until the container is up and running

So before it was just using "127.0.0.1:0" as a placeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants