-
Notifications
You must be signed in to change notification settings - Fork 699
limactl help and info flag should show available plugins #4009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
limactl help and info flag should show available plugins #4009
Conversation
9993a6e
to
e012aa1
Compare
e012aa1
to
6854c86
Compare
6854c86
to
51673df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the docs changes, but here is some feedback on the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs review
f2fea51
to
2d073bc
Compare
Signed-off-by: olalekan odukoya <[email protected]>
2d073bc
to
ff781c8
Compare
BATS failing
https://github.com/lima-vm/lima/actions/runs/17775630264/job/50573056648?pr=4009 |
externalCmd := "limactl-" + name | ||
execPath, err := exec.LookPath(externalCmd) | ||
if err != nil { | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mentioned this before that you should use the path to the plugin from the discovery code and not call exec.LookPath
, which might find a different version of the plugin in case there are bugs in the discovery algorithm.
Use the same list in both places to make sure the behaviour is always in sync!
Fixes #3608 (comment)