portfwd: close ClosableListeners on exit
#4031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HostSocket will be deleted on close. Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
close-grpc-forwarder
branch
from
58899cc to
729b200
Compare
|
Thanks! 🙏🏻 |
norio-nomura
commented
Sep 18, 2025
| @@ -90,6 +105,9 @@ func (p *ClosableListeners) forwardTCP(ctx context.Context, client *guestagentcl | |||
| for { | |||
| conn, err := tcpLis.Accept() | |||
| if err != nil { | |||
| if opErr, ok := err.(*net.OpError); ok && opErr.Err.Error() == "use of closed network connection" { | |||
There was a problem hiding this comment.
This should be changed to use if errors.Is(err, net.ErrClosed) {
opened #4048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostSocketwill be deleted on close.Separated from #4008