Splinetoy! #7
Closed
Splinetoy! #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- supress click when handled by toolbar - fix swapped placeholder auto point position - treat trailing point as auto
This is common UX in tools like this; shift+click with the pen tool aligns the point with the previous point. Similar behaviour is added for dragging and adjusting handles.
This doesn't combine the first/last points when a path is closed, but otherwise seems to work okay.
This does the trick where a single point represents both the first 'moveto' and the final lineto/splineto point.
- fix crash when deleting first point - remove empty paths after removing last point
- this also fixes a crash when adding a point to an open path
|
closed in favor of #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial simple implementation of the UX for the new spline.
This is barebones: there are two tools, 'select' and 'pen', and editing is currently limited to a single subpath. A single point can be manipulated at a time. I've done my best to emulate the behaviour described in linebender/runebender#182, but there are clearly some rough patches & open questions. Deleting off-curve points doesn't work, and probably should; adjusting a handle on a smooth point does not maintain curvature; and I'm sure there are numerous other things.
I would also like to get this working with wasm so that it can be deployed on the web, but that can be a next step.
@raphlinus I'd be curious to hear your thoughts after playing with this a little bit.