Skip to content

Update to ui-events and ui-events-winit 0.2.0. - #1103

Merged
xorgy merged 1 commit into
linebender:mainfrom
xorgy:ui-events-0.2.0
Oct 28, 2025
Merged

Update to ui-events and ui-events-winit 0.2.0.#1103
xorgy merged 1 commit into
linebender:mainfrom
xorgy:ui-events-0.2.0

Conversation

@xorgy

@xorgy xorgy commented Jun 24, 2025

Copy link
Copy Markdown
Member

No description provided.

@xorgy
xorgy requested a review from waywardmonkeys June 24, 2025 15:21
@xorgy
xorgy force-pushed the ui-events-0.2.0 branch from 39583ab to 7298203 Compare June 25, 2025 23:59
@waywardmonkeys

waywardmonkeys commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Can you rebase this forward?

DJMcNab
DJMcNab reviewed Jul 1, 2025
View reviewed changes

@DJMcNab DJMcNab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good (once this is released)

Comment thread masonry/src/widgets/button.rs Outdated
Comment thread masonry/src/widgets/portal.rs Outdated
Comment thread masonry/src/widgets/virtual_scroll.rs
delta: ScrollDelta::PixelDelta(PhysicalPosition::<f64> { x: 0., y: 25. }),
state: PointerState::default(),
});
harness.mouse_wheel(Vec2 { x: 0., y: 25. });

@DJMcNab DJMcNab Jul 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@xorgy
xorgy force-pushed the ui-events-0.2.0 branch from 7298203 to 8f7a566 Compare July 2, 2025 03:56
@xorgy

xorgy commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

Would like a yes/no on the destructuring-based version (second commit) vs the opaque version (first commit), as we're about to do an ui-events-0.2.0 so we need to choose one. :+ )

@waywardmonkeys

waywardmonkeys commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

@DJMcNab That's a plea for you to comment on that. :)

@waywardmonkeys
waywardmonkeys requested a review from DJMcNab August 13, 2025 10:13
@DJMcNab

DJMcNab commented Aug 13, 2025

Copy link
Copy Markdown
Member

Destructuring is fine by me. It's certainly better than extremely short names.
The lines like PointerEvent::Up(PointerButtonEvent { button, ..}) => having two instances of each of Pointer and Event isn't great, but I don't see that being avoidable (without inline structs or equivalent).

@xorgy
xorgy force-pushed the ui-events-0.2.0 branch 2 times, most recently from a632a69 to 5f27425 Compare September 3, 2025 14:25
@xorgy xorgy mentioned this pull request Sep 3, 2025
Closed
@xorgy
xorgy marked this pull request as ready for review October 28, 2025 03:22
@xorgy

xorgy commented Oct 28, 2025

Copy link
Copy Markdown
Member Author

Alright, we've now published ui-events and ui-events-winit v0.2.0, and this branch is up to date for that. :+ )

waywardmonkeys
waywardmonkeys approved these changes Oct 28, 2025
View reviewed changes

@waywardmonkeys waywardmonkeys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would still like to get feedback from @DJMcNab on this.

DJMcNab
DJMcNab approved these changes Oct 28, 2025
View reviewed changes

@DJMcNab DJMcNab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the blocking rebase artifact, this looks good. I do have a couple of other thoughts, but nothing too significant.

Thanks!

Comment thread masonry/examples/layers.rs
Comment thread masonry/src/widgets/text_area.rs Outdated
Comment thread masonry/src/widgets/text_area.rs
Comment thread masonry/Cargo.toml Outdated
@DJMcNab DJMcNab mentioned this pull request Oct 28, 2025
Merged
@xorgy
xorgy enabled auto-merge October 28, 2025 15:12
@xorgy
xorgy added this pull request to the merge queue Oct 28, 2025
Merged via the queue into linebender:main with commit de88321 Oct 28, 2025
17 checks passed
@xorgy
xorgy deleted the ui-events-0.2.0 branch October 28, 2025 15:30
github-merge-queue Bot pushed a commit that referenced this pull request Oct 29, 2025
@DJMcNab
Release Xilem/Masonry v0.4.0, Tree Arena v0.2.0 (#1435)
001282d 
See discussion in [#xilem >
v0.4.0](https://xi.zulipchat.com/#narrow/channel/354396-xilem/topic/v0.2E4.2E0/with/547457987).
Target date is tomorrow to just let everything settle (e.g. #1103).

https://linebender.org/wiki/process/release/#checklist

I have run a publish dry run, using the command:
```sh
cargo publish --dry-run -p xilem -p xilem_core -p masonry -p masonry_core -p masonry_winit -p masonry_testing -p tree_arena -p xilem_web
```
We don't have a changelog (yet, plan is to start immediately after this
releasee), we have bumped dependencies (pending #1103).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes
@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xorgy @waywardmonkeys @DJMcNab