- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.2k
 
Increase upper bound for inbox size metric #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
  This was referenced Apr 9, 2025 
      
          
 This stack of pull requests is managed by Graphite. Learn more about stacking.  | 
    
              
                    ma2bd
  
              
              approved these changes
              
                  
                    Apr 9, 2025 
                  
              
              
            
            
dd1f8e1    to
    9e06304      
    Compare
  
    cd7e8d6    to
    212506f      
    Compare
  
    9e06304    to
    82a3793      
    Compare
  
    212506f    to
    936230c      
    Compare
  
    82a3793    to
    c940ad5      
    Compare
  
    936230c    to
    0840bd6      
    Compare
  
    
  This was referenced Apr 11, 2025 
      
     Closed
  
      
     Merged
  
0840bd6    to
    5ca761a      
    Compare
  
    c940ad5    to
    94539ed      
    Compare
  
    94539ed    to
    b9d130e      
    Compare
  
    
  This was referenced Apr 14, 2025 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Motivation
I've seen inbox size p99 reach half a million during benchmarks
Proposal
Bump it to 2 million
Test Plan
Will deploy a network with this
Release Plan