Introduce another KeyValueStoreView
#4387
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDutSik
force-pushed
the
small_key_value_store_B
branch
2 times, most recently
from
0d549f1 to
134a3f8
Compare
MathieuDutSik
force-pushed
the
small_key_value_store_B
branch
from
b94001d to
83ad3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
KeyValueStoreViewis a scalable solution. But it may be faster to use aBTreeMapbased solution that is faster for small cases.Proposal
We introduce the
SmallKeyValueStoreViewthat uses aRegisterViewon aBTreeMap.However, we cannot use the derive, so we write the
SmallKeyValueStoreViewdirectly.The switch is accessible by using the feature
smallkeyvaluestoreviewso as to select the smallkey-value-store view.
Test Plan
The CI.
More benchmarks are needed. This is only a draft PR so far.
Release Plan
Links
None.